[FEAT/#87] 인증 동네 리스트 조회 구현 #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckkim817
reviewed
Feb 18, 2025
| @@ -48,7 +48,7 @@ public enum ErrorType { | |||
| INVALID_FAVORITE_SPOT_ERROR(HttpStatus.BAD_REQUEST, 40017, "유효하지 않은 favoriteSpot입니다."), | |||
| INVALID_FAVORITE_SPOT_RANK_SIZE_ERROR(HttpStatus.BAD_REQUEST, 40030, "favoriteSpotRank의 사이즈가 잘못되었습니다."), | |||
| INVALID_FAVORITE_CUISINE_RANK_SIZE_ERROR(HttpStatus.BAD_REQUEST, 40031, "favoriteCuisineRank의 사이즈가 잘못되었습니다."), | |||
| ALREADY_VERIFIED_AREA_ERROR(HttpStatus.BAD_REQUEST, 40032, "이미 인증된 동네가 존재합니다."), | |||
| INVALID_AREA_NUMBER_ERROR(HttpStatus.BAD_REQUEST, 40032, "동네 인증은 최소 1개 ~ 최대 5개까지 가능합니다."), | |||
There was a problem hiding this comment.
P3:
진짜 별 거 아닌데 NUMBER 대신 COUNT 어떠신지 ㅎㅅㅎ
그리고 요 에러 명세에 없던데 명세에도 추가해 주세요 ~!
There was a problem hiding this comment.
e478457
통일성을 위해 SIZE로 사용했습니당
There was a problem hiding this comment.
이 에러 동네 인증하기 명세에 이미 있습니당~
| @@ -61,6 +62,7 @@ public class MemberService { | |||
| private static final char[] CHARACTERS = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789_.".toCharArray(); | |||
| private static final int MAX_NICKNAME_LENGTH = 16; | |||
| private static final String NICKNAME_PATTERN = "^[a-zA-Z0-9_.가-힣]+$"; | |||
| private static final int MAX_VERIFIED_AREA_LIST = 5; | |||
There was a problem hiding this comment.
e478457
SIZE 사용했습니당
| List<VerifiedAreaEntity> verifiedAreaEntityList = verifiedAreaRepository.findAllByMemberId( | ||
| memberEntity.getId()); | ||
|
|
||
| if (verifiedAreaEntityList.size() > MAX_VERIFIED_AREA_LIST - 1) { |
There was a problem hiding this comment.
P3:
개인적으로 -1 쓰는 거 대신 >=를 쓰는 게 더 이뻐보여요 !
| memberEntity.getId()); | ||
| List<VerifiedAreaListResponse.VerifiedArea> verifiedAreaList = verifiedAreaEntityList.stream() | ||
| .map(verifiedAreaEntity -> new VerifiedAreaListResponse.VerifiedArea(verifiedAreaEntity.getId(), | ||
| verifiedAreaEntity.getName())) |
There was a problem hiding this comment.
P2:
-
VerifiedAreaListResponse 내부에 VerifiedArea를 만들어서 사용하는 것보다 이미 있는 VerifiedAreaResponse를 사용하는 건 어떨까요? (제안)
-
new를 통한 객체 생성보다는 정적 팩토리 메서드 방식으로 바꿔주면 좋을 것 같아용
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 Issue
📄 Description
💬 To Reviewers